Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CMake option to link MSVC runtime library statically #224

Closed
wants to merge 2 commits into from
Closed

Conversation

tbeu
Copy link
Owner

@tbeu tbeu commented Nov 19, 2023

No description provided.

@tbeu tbeu requested a review from MaartenBent November 19, 2023 21:10
Copy link
Collaborator

@MaartenBent MaartenBent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only did a code review. I have not yet tried to build it.

cmake/options.cmake Outdated Show resolved Hide resolved
cmake/options.cmake Outdated Show resolved Hide resolved
cmake/options.cmake Show resolved Hide resolved
@tbeu tbeu force-pushed the master branch 13 times, most recently from ae06e5b to a19f419 Compare February 7, 2024 22:31
@tbeu tbeu force-pushed the master branch 13 times, most recently from c102e74 to 75634b5 Compare February 9, 2024 21:02
@tbeu tbeu force-pushed the master branch 6 times, most recently from f249429 to 8442fbc Compare February 9, 2024 21:46
@tbeu
Copy link
Owner Author

tbeu commented Feb 10, 2024

Because of dependencies it is hard to get it consistently right. Closing.

@tbeu tbeu closed this Feb 10, 2024
@tbeu tbeu deleted the cmake-3 branch February 10, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants